Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Collection): toJSON() errors if the collection includes empty values #5129

Merged
merged 1 commit into from Dec 26, 2020
Merged

fix(Collection): toJSON() errors if the collection includes empty values #5129

merged 1 commit into from Dec 26, 2020

Conversation

vaporoxx
Copy link
Contributor

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit 2c2249e into discordjs:master Dec 26, 2020
@haroongames-git
Copy link

To be honest, I don't think this should actually be added.
I'm using the github version of d.js, and whenever I initialize a Collection, my code throws SyntaxError: Unexpected token '.'

This could break a whole lot of users' code.

@anandre
Copy link
Contributor

anandre commented Jan 20, 2021

v13 introduces breaking changes, including a new Node version requirement, just like the update from v11 to v12 did (Node 8 -> Node 12). v13 will require Node 14 or higher, to take advantage of new features for cleaner code and better functions. Since a recent-ish commit, master requires Node 14 or higher.

@vaporoxx vaporoxx deleted the fix-collection branch March 25, 2021 23:40
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants