Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MessageEmbed): include author.name in length getter #5167

Merged
merged 4 commits into from Dec 31, 2020
Merged

fix(MessageEmbed): include author.name in length getter #5167

merged 4 commits into from Dec 31, 2020

Conversation

xiBread
Copy link
Contributor

@xiBread xiBread commented Dec 31, 2020

Please describe the changes this PR makes and why it should be merged:
Fixes #5166

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

xiBread and others added 2 commits December 31, 2020 01:55
@xiBread @papaia
Update src/structures/MessageEmbed.js
65b7f7b 
Co-authored-by: Papaia <43409674+papaia@users.noreply.github.com>
@xiBread @papaia
style: oxford comma
43c4fb0 
Co-authored-by: Papaia <43409674+papaia@users.noreply.github.com>
@iCrawl iCrawl merged commit e37160f into discordjs:master Dec 31, 2020
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papaia papaia papaia left review comments

@NotSugden NotSugden NotSugden requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

embed.length(): Missing author.name.length from character count
8 participants
@xiBread @vladfrangu @iCrawl @kyranet @SpaceEEC @NotSugden @papaia @notMorrow