Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GuildEmoji): check for changes to available in equals #5201

Merged
merged 1 commit into from Jan 22, 2021

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Jan 10, 2021

The available property was unchecked in GuildEmoji#equals causing updates to available to go uncached.
closes: #5200

I do not have an available guild where the state of available can change to test this on, please do test this if you can.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit f95f5dc into discordjs:master Jan 22, 2021
@ckohen ckohen deleted the fix-emoji-equals branch February 6, 2021 11:08
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GuildEmoji#available does not update correctly when guild loses boost a level
5 participants