feat(BitField): move problematic bit into the error message #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
approved these changes
Jan 19, 2021
vaporoxx
reviewed
Jan 19, 2021
vladfrangu
approved these changes
Jan 19, 2021
SpaceEEC
approved these changes
Jan 19, 2021
iCrawl
approved these changes
Jan 22, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR moves the invalid bit for BITFIELD_INVALID errors into the error message. This was previously the preferred approach, reverted due to forcing semver major by changing a public-facing message (#4617).
This should greatly increase the visibility of invalid bits being passed in various places, reducing the number of requests regarding typos and outright wrong flags being used in support.
Status
Semantic versioning classification: