fix(GuildChannel): regression on default channel type

[almostSouji]

Please describe the changes this PR makes and why it should be merged:

⚠️ closes #5273

The merge of #5022 has caused a regression, which this PR aims to fix.

When no channel is provided in data the PR defaults to this.type. This is however not the required numerical for the channel type the API expects resulting in

DiscordAPIError: Invalid Form Body
type: Value "text" is not int.

The other case (type is present in data) chooses to do the defaulting through the ChannelTypes enum and uppercasing the expected text value, which I have accordingly replicated in the defaulting case.

Status

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

• This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
• This PR only includes non-code changes, like changes to documentation, README, etc.

[Koyamie]

Shouldn't we still use this.type if no new type is sent to the data object ?

I was thinking about this:

type: ChannelTypes[(data.type || this.type).toUpperCase()],

[almostSouji]

Not required, has no benefit: https://discord.com/developers/docs/resources/channel#modify-channel

All JSON parameters are optional.

Aka: you just need to pass what you actually want to edit, meaning undefined (which this will otherwise result in) is valid

[Koyamie]

Not required, has no benefit: https://discord.com/developers/docs/resources/channel#modify-channel

All JSON parameters are optional.

Aka: you just need to pass what you actually want to edit, meaning undefined (which this will otherwise result in) is valid

Alright, thanks 👍

Stale

[almeidx]

You mentioned this pull request instead of the #5273 issue in the pull request description

[WilcoSp]

it would be better if instead of using uppercased channel type name to use instead an integer that discord uses to represent a type https://discord.com/developers/docs/resources/channel#channel-object-channel-types

this how it looks for my own quick fix but off course for the library it would be better to map each type to an integer

note: I only use the function to mass change permissions when a server owner changes the verify channel for my verification bot

[almostSouji]

it would be better if instead of using uppercased channel type name to use instead an integer

This is out of scope of this regression fix - we might do so going forward, as mentioned by vlad above:

You could argue we don't support numbers as types, but that should come if we ever replace string types with numbers