feat: GuildBanManager #5276
Merged
feat: GuildBanManager #5276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaida04
suggested changes
Jan 31, 2021
NotSugden
suggested changes
Jan 31, 2021
vaporoxx
reviewed
Jan 31, 2021
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
NotSugden
suggested changes
Feb 1, 2021
vaporoxx
reviewed
Feb 2, 2021
Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
tguichaoua
suggested changes
Feb 5, 2021
NotSugden
suggested changes
Feb 5, 2021
Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
…nto banmanager
vaporoxx
reviewed
Feb 6, 2021
This reverts commit 598ba38.
… discordjs-master
NotSugden
reviewed
Mar 16, 2021
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
vladfrangu
requested changes
Mar 26, 2021
vladfrangu
approved these changes
Mar 26, 2021
iShibi
reviewed
Mar 26, 2021
Co-authored-by: Shubham Parihar <shubhamparihar391@gmail.com>
kyranet
approved these changes
Mar 26, 2021
iCrawl
approved these changes
Mar 27, 2021
|
|
MBR-0001
changed the title
iShibi
reviewed
Mar 28, 2021
Co-authored-by: Shubham Parihar <shubhamparihar391@gmail.com>
cosmicice0
approved these changes
Apr 21, 2021
SpaceEEC
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR adds
GuildBanManagerto guilds, it replacesguild#fetchBans/guild#fetchBanand adds a ban cache (which is most of the time partial). I decided to add this because actions like fetching guild ban count or checking if a member is banned required sending a request to Discord every single time (or manually handling ban/unban events lol)I've been using this with my bots for probably 4 months now and didn't have any issues (afaik)
(a lot of comments/docs are copied from other classes lol)
Status and versioning classification:
Please be gentle, this is my first time