fix(GuildMember): correctly check for premium_since #5312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fyko
approved these changes
Feb 10, 2021
papaia
approved these changes
Feb 10, 2021
kyranet
approved these changes
Feb 10, 2021
|
How does Discord propagate this property changing to |
kyranet
approved these changes
Feb 11, 2021
vladfrangu
approved these changes
Apr 3, 2021
not sure, I would assume though that |
SpaceEEC
approved these changes
Apr 14, 2021
vaporoxx
reviewed
Apr 14, 2021
Comment on lines
+88
to
+90
| if ('premium_since' in data) { | ||
| this.premiumSinceTimestamp = data.premium_since === null ? null : new Date(data.premium_since).getTime(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if ('premium_since' in data) { | |
| this.premiumSinceTimestamp = data.premium_since === null ? null : new Date(data.premium_since).getTime(); | |
| } | |
| if ('premium_since' in data) this.premiumSinceTimestamp = data.premium_since && new Date(data.premium_since).getTime(); |
iCrawl
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR fixes a bug introduced by #4636,
GuildMember#premiumSinceTimestampwas being set to 0 every time rather than nullStatus and versioning classification: