Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Role): pass Permissions class, not the bitfield #5321

Merged
merged 2 commits into from Feb 22, 2021
Merged

fix(Role): pass Permissions class, not the bitfield #5321

merged 2 commits into from Feb 22, 2021

Conversation

vaporoxx
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

The toJSON() method from the Permissions class returns the bitfield as a string, however the bitfield is passed directly here, resulting in TypeError: Do not know how to serialize a BigInt

Status and versioning classification:

  • Typings don't need updating

src/structures/Role.js Outdated Show resolved Hide resolved
@kyranet kyranet requested a review from iCrawl February 14, 2021 18:55
@iCrawl iCrawl merged commit d744e51 into discordjs:master Feb 22, 2021
@vaporoxx vaporoxx deleted the fix-edit branch March 25, 2021 23:40
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Role>.setPermissions does not accept BigInt
6 participants