Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GuildManager): add missing toString() on Permission#resolve fns #5324

Merged
merged 1 commit into from Mar 28, 2021

Conversation

Fyko
Copy link
Contributor

@Fyko Fyko commented Feb 14, 2021

Please describe the changes this PR makes and why it should be merged:
This PR adds missing toString functions on various Permissions#resolve(...) functions within GuildManager#create.
This should be treated with high severity.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative to this would have been doing new Permissions() since its toJSON() serializes the data correctly, but this also works.

@iCrawl iCrawl changed the title fix(GuildManager#create): add missing toString() on Permission#resolve fns fix(GuildManager): add missing toString() on Permission#resolve fns Mar 28, 2021
@iCrawl iCrawl merged commit 0778926 into discordjs:master Mar 28, 2021
@Fyko Fyko deleted the fix/permissions branch March 28, 2021 13:37
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants