New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(WelcomeScreen): welcome screens #5490
Conversation
afeaedd
to
b87acf8
Compare
Is it intentional to not populate / overwrite / update |
Not too sure how to handle any of this for what it's worth
An entirely different approach could be to emit an InviteGuild which is directly attached to invites and reflects the guilds state at the point the invite was created/arrived, so we don't have outdated data in caches. This problem also arises with interactions and the new #permissions field which reflects permissions after overwrites are applied in the channel the interaction was used in at the time the interaction was used. |
how should i handle welcome screen data from invite guilds? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing I have to say is #5490 (comment)
Option c sounds ideal, but I don't know what others think. @iCrawl @kyranet? |
Option C sounds reasonable (maybe a bit overkill, but what isn't in the current state of the library) and in line with the pattern we do it for other resources. |
There are merge conflicts in this PR, please rebase @almostSouji. Also, since this seems blocked/pending review resolution, should this be marked as draft? |
627fb8e
to
be3892a
Compare
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
f627236
to
516f537
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a mention of InviteGuild
in BaseGuild
too (and mark it as @abstract
) while are at it? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think BaseGuild
also needs an abstract
in the typings.
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
This reverts commit 38aca5e.
reverted accepting broader emoji data after internal discussion following proposal #5839 |
Please describe the changes this PR makes and why it should be merged:
Implement
Guild#fetchWelcomeScreen
,Guild#editWelcomeScreen
, add welcome screen data to invites retrieved via invite fetching (Client#fetchInvite
) as per:Notes:
QoL change forBaseGuildEmojiManager
to accept the<:name:id>
andname:id
syntax in resolve* methodsUpstream:
Status and versioning classification: