Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GuildAuditLogsEntry): executor can be missing #5500

Merged
merged 1 commit into from Apr 14, 2021

Conversation

almostSouji
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

As per discord/discord-api-docs#1659 user_id is nullable, which should accordingly be handled in GuildAuditLogsEntry#executor

ℹ️ Note: This is the case when a webhook is deleted using a webhook token rather than a user or bot through a guild.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl merged commit e9bf206 into discordjs:master Apr 14, 2021
@almostSouji almostSouji deleted the fix/audit-executor branch April 14, 2021 22:38
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants