Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GuildManager): allow system channel flags in create #5504

Merged
merged 4 commits into from Apr 30, 2021

Conversation

almostSouji
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Allow systemChannelFlags to be passed during guild creation as per discord/discord-api-docs#1764

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

typings/index.d.ts Outdated Show resolved Hide resolved
@kyranet kyranet requested review from SpaceEEC and iCrawl April 9, 2021 08:45
@SpaceEEC
Copy link
Member

I'm unable to get this working, the system channel flags are always 0 in the response body / guild create payload.

@almostSouji
Copy link
Member Author

almostSouji commented Apr 14, 2021

Did some digging:

  • the data we receive from POST /guilds has the correct flags set (3)
  • the data we receive from the GUILD_CREATE websocket event has no flags set (0)
  • getting data after the fact from GET /guilds/:id also has the correct flags set (3)
  • the setting is applied, but the client seems to encounter that issue as well (the toggles show that the messages are enabled, they are however not sent)
  • if GUILD_CREATE wins the race we use that data for the response (the raw response body seems to have the correct flags)

So in conclusion that seems to be a discord bug and nothing we can handle on our end (if the GC arrives earlier we use that data in the #create response)

Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll see if Discord can resolve this.

@iCrawl iCrawl merged commit d9fa180 into discordjs:master Apr 30, 2021
@almostSouji almostSouji deleted the feat/guildmanager-create-opt branch April 30, 2021 23:11
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants