Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Guild): allow description and features in edit #5505

Merged
merged 4 commits into from Apr 27, 2021

Conversation

almostSouji
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

  • Guild#edit now allows modification of features (COMMUNITY, to enable community features)
  • Guild#edit now allows the discovery description to be modified

as per discord/discord-api-docs#1764

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

src/structures/Guild.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
@SpaceEEC
Copy link
Member

I'm unable to set a description (just silently fails on Discord's end), probably due to not being on discovery.

Further enabling community only works when the payload also includes a rules and public updates channel (does not matter if you previously set them).
Otherwise you are getting the very helpful and totally not misleading error This feature has been temporarily disabled (The code is 40006, if somebody is interested).

I don't think there is much we can do about either though.

typings/index.d.ts Outdated Show resolved Hide resolved
@kyranet kyranet requested a review from iCrawl April 14, 2021 19:42
@iCrawl iCrawl merged commit 8a059cc into discordjs:master Apr 27, 2021
@almostSouji almostSouji deleted the feat/guild-edit-opt branch April 27, 2021 07:41
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants