Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Emoji): name can be null #5513

Merged
merged 1 commit into from Apr 30, 2021
Merged

fix(Emoji): name can be null #5513

merged 1 commit into from Apr 30, 2021

Conversation

almostSouji
Copy link
Member

@almostSouji almostSouji commented Apr 9, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:

Emoji#name can be null when received as reaction emojis, in case of:

  1. unavailable custom emojis (based on guild boost level)
  2. message history being queried

ℹ️ While technically breaking this should be considered a fix to handle existing API behavior properly.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@kyranet kyranet requested a review from iCrawl April 30, 2021 12:27
@iCrawl iCrawl merged commit 5397021 into discordjs:master Apr 30, 2021
@almostSouji almostSouji deleted the fix/emoji-name branch April 30, 2021 23:06
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@almostSouji @vladfrangu @iCrawl @kyranet @SpaceEEC