New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GuildChannel): createInvite target options #5514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
almostSouji
force-pushed
the
feat/invite-target
branch
2 times, most recently
from
April 10, 2021 11:21
1236880
to
38c60f3
Compare
almostSouji
force-pushed
the
feat/invite-target
branch
2 times, most recently
from
April 11, 2021 01:22
ff9e8e6
to
4fa4136
Compare
kyranet
requested changes
Apr 12, 2021
kyranet
requested changes
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with many other methods (e.g. Guild#iconURL, Guild#splashURL, User#avatarURL, etc):
kyranet
approved these changes
Apr 12, 2021
advaith1
suggested changes
Apr 18, 2021
advaith1
reviewed
Apr 18, 2021
CyberFlameGO
approved these changes
Apr 25, 2021
iCrawl
approved these changes
Apr 30, 2021
SpaceEEC
approved these changes
May 10, 2021
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
Co-authored-by: Advaith <advaithj1@gmail.com>
Co-authored-by: Advaith <advaithj1@gmail.com>
almostSouji
force-pushed
the
feat/invite-target
branch
from
May 10, 2021 11:33
daeaa57
to
e67e698
Compare
vladfrangu
previously requested changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Invite accepts a target as documented in:
target_user_id
field and addpublic_flags
to example user objects discord/discord-api-docs#1708Target can be a user (has to be streaming in the VC the invite targets) or an embedded application (has to play VC activity in the VC the invite targets).
In order to facilitate this the following changes have been made:
.createInvite(...)
add and handle option keystargetType
,targetUser
andtargetApplication
Invite#targetUser
should be "of this invite", "for" is used for creationTODO:
hook (boolean)
indicate in application data?verify_key (string)
indicate in application data?verify_key
Status and versioning classification: