Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CategoryChannelResolvable for parent setting #5521

Closed
almostSouji opened this issue Apr 11, 2021 · 1 comment · Fixed by #6232
Closed

Use CategoryChannelResolvable for parent setting #5521

almostSouji opened this issue Apr 11, 2021 · 1 comment · Fixed by #6232

Comments

@almostSouji
Copy link
Member

almostSouji commented Apr 11, 2021

Is your feature request related to a problem? Please describe.
During the setup of #5507 it came to attention that categories are currently typed as ChannelResolvable whenever we ask for a potential parent channel

Describe the ideal solution
The type and documentation could be more specific by introducing a CategoryResolvable type

Describe alternatives you've considered
n/a

Additional context
n/a

@almostSouji almostSouji changed the title Introduce CategoryResolvable for parent setting Use CategoryResolvable for parent setting Apr 11, 2021
@almostSouji almostSouji changed the title Use CategoryResolvable for parent setting Use CategoryChannelResolvable for parent setting Apr 12, 2021
@polypixeldev
Copy link

I also think that a CategoryResolvable type would help work with categories since it is a little confusing having them as a channel This feature would definitely help clarify some things.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants