New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ApplicationCommandManager): limit permission methods to guilds #5613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also add a <warn>
ing in the ApplicationCommand
methods docstrings?
This is incorrect: global commands can have permissions, but the permissions must be set per-server |
Yes, but that needs to be done through the manager, so saying "This method cannot be used" on the command class method is still correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please describe the changes this PR makes and why it should be merged:
These endpoints are not available for global commands.
Status and versioning classification: