feat(Widget): wrapper for widget.json #5619

Thumuss · 2021-05-13T03:30:01Z

Please describe the changes this PR makes and why it should be merged:
Okay, I'm remaking a new pr because my last was really terrible + i've deleted the original (#5030)

My goal is to add Widget in discord.js
Widget is a part of Discord and it's not fully featured

Status and versioning classification:

I know how to update typings and have done so, or typings don't need updating
Code changes have been tested against the Discord API, or there are no code changes
This PR changes the library's interface (methods or parameters added)

Thanks to @ckohen @advaith1 @SpaceEEC @almostSouji @vladfrangu @NotSugden @kyranet @Mesteery for helping me in the last pull request

typings/index.d.ts

src/structures/Widget.js

src/client/Client.js

src/structures/Widget.js

typings/index.d.ts

Co-authored-by: monbrey <rsm999@uowmail.edu.au>

Thumuss · 2021-05-13T04:14:26Z

It's a mess in the logs but I've added in client an Promise.reject in Client#fetchWidget + clean up the if condition in the Widget class

src/client/Client.js

src/structures/Widget.js

Thumuss · 2021-05-13T19:38:08Z

I have add a new function, exactly the same as the Client#fetchWidget but in the Widget to update the widget
And I fixed the jsdoc like you said vladfrangu

typings/index.d.ts

src/structures/Widget.js

CamelCase Co-authored-by: BannerBomb <BannerBomb55@gmail.com>

Thumuss · 2021-05-27T18:42:18Z

I have done a test but that change anything I guess ? I've just link my local to my github project (3ead9e6)

typings/index.d.ts

src/structures/WidgetMember.js

Co-authored-by: Antonio Román <kyradiscord@gmail.com>

…e changed, moved WidgetMember#_patch to constructor

Stale

SpaceEEC

Otherwise LGTM

src/index.js

Co-authored-by: SpaceEEC <spaceeec@yahoo.com>

Stale

kyranet

Just some formatting things for consistency, otherwise LGTM

src/structures/WidgetMember.js

src/structures/Widget.js

src/structures/WidgetMember.js

Thumuss · 2021-06-09T18:28:09Z

Something I didn't see was the property fetchWidget in Guild (Guild#fetchWidget).
It's actually an other api request. I'm thinking about rename Guild#fetchWidget to Guild#fetchWidgetOption and re use the Client#fetchWidget for Guild#fetchWidget
It is a good idea or do I need to do something else ?

src/structures/WidgetMember.js

src/structures/Widget.js

Stale

Thumuss · 2021-06-10T20:56:05Z

Before push it, do we need add a Guild#fetchWidget like I said upper ?

src/structures/Widget.js

src/structures/WidgetMember.js

typings/index.d.ts

Stale

add(Widget): wrapper for widget.json

50100f9

Thumuss mentioned this pull request May 13, 2021

Add new wrapper Widget #5030

Closed

5 tasks

Thumuss commented May 13, 2021

View reviewed changes

typings/index.d.ts Outdated Show resolved Hide resolved

Thumuss commented May 13, 2021

View reviewed changes

typings/index.d.ts Show resolved Hide resolved

Thumuss commented May 13, 2021

View reviewed changes

src/structures/Widget.js Outdated Show resolved Hide resolved

monbrey reviewed May 13, 2021

View reviewed changes

Thumuss and others added 2 commits May 13, 2021 05:45

Use Async

3b79d53

Co-authored-by: monbrey <rsm999@uowmail.edu.au>

fix: Create an error when widget is disabled

44d8239

PyroTechniac suggested changes May 13, 2021

View reviewed changes

src/client/Client.js Outdated Show resolved Hide resolved

fix: throw directly errors (async)

a523414

vladfrangu added reason: API support labels May 13, 2021

vladfrangu previously requested changes May 13, 2021

View reviewed changes

src/client/Client.js Outdated Show resolved Hide resolved

src/structures/Widget.js Outdated Show resolved Hide resolved

src/structures/Widget.js Outdated Show resolved Hide resolved

src/structures/Widget.js Outdated Show resolved Hide resolved

Thumuss added 3 commits May 13, 2021 19:46

fix: change jsdoc + camelCase

9a70ef4

add(Widget#fetch): added to update the widget

64cbb65

fix: .d.ts with Promise<Widget> in Widget#fetch

9ec7170

kyranet changed the title ~~add(Widget): wrapper for widget.json~~ feat(Widget): wrapper for widget.json May 13, 2021

Thumuss requested a review from vladfrangu May 13, 2021 21:20

BannerBomb reviewed May 20, 2021

View reviewed changes

typings/index.d.ts Outdated Show resolved Hide resolved

BannerBomb reviewed May 20, 2021

View reviewed changes

typings/index.d.ts Outdated Show resolved Hide resolved

BannerBomb reviewed May 20, 2021

View reviewed changes

src/structures/Widget.js Outdated Show resolved Hide resolved

Thumuss and others added 5 commits May 27, 2021 02:24

Update typings/index.d.ts

cde478d

CamelCase Co-authored-by: BannerBomb <BannerBomb55@gmail.com>

Update typings/index.d.ts

490e52e

CamelCase Co-authored-by: BannerBomb <BannerBomb55@gmail.com>

test

3ead9e6

Merge branch 'master' of https://github.com/ThumusLive/feature-widget

d3e90ba

Probleme resolved

c9f6860

Forgot client in the function

b346322

kyranet previously requested changes Jun 7, 2021

View reviewed changes

typings/index.d.ts Show resolved Hide resolved

src/structures/WidgetMember.js Outdated Show resolved Hide resolved

src/structures/WidgetMember.js Show resolved Hide resolved

src/structures/WidgetMember.js Show resolved Hide resolved

Thumuss and others added 3 commits June 8, 2021 21:01

avatarUrl => avatarURL

47a6f9f

Co-authored-by: Antonio Román <kyradiscord@gmail.com>

Typedef updated for client & WidgetMember added & Widget#instantInvit…

cf8ed85

…e changed, moved WidgetMember#_patch to constructor

Add WidgetActivity doc in WidgetMember

0911dd8

Thumuss requested a review from kyranet June 9, 2021 01:32

SpaceEEC previously requested changes Jun 9, 2021

View reviewed changes

src/index.js Show resolved Hide resolved

Update src/index.js

11cc73f

Co-authored-by: SpaceEEC <spaceeec@yahoo.com>

kyranet requested changes Jun 9, 2021

View reviewed changes

docs: format lines for consistency

e4167a4

kyranet approved these changes Jun 9, 2021

View reviewed changes

SpaceEEC approved these changes Jun 9, 2021

View reviewed changes

kyranet requested a review from iCrawl June 9, 2021 12:58

vladfrangu requested changes Jun 9, 2021

View reviewed changes

Fixed docstring + string=>number for WidgetMember#id

e162ece

vladfrangu previously requested changes Jun 9, 2021

View reviewed changes

src/structures/WidgetMember.js Outdated Show resolved Hide resolved

src/structures/Widget.js Outdated Show resolved Hide resolved

iCrawl requested a review from vladfrangu June 10, 2021 07:40

vladfrangu previously requested changes Jun 12, 2021

View reviewed changes

src/structures/Widget.js Outdated Show resolved Hide resolved

src/structures/WidgetMember.js Outdated Show resolved Hide resolved

typings/index.d.ts Show resolved Hide resolved

Revert parseInt

41c797d

iCrawl approved these changes Jun 15, 2021

View reviewed changes

iCrawl merged commit 038ee99 into discordjs:master Jun 15, 2021

iCrawl added this to the Version 13 milestone Jun 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Widget): wrapper for widget.json #5619

feat(Widget): wrapper for widget.json #5619

Thumuss commented May 13, 2021 •

edited

Thumuss commented May 13, 2021 •

edited

Thumuss commented May 13, 2021 •

edited

Thumuss commented May 27, 2021 •

edited

SpaceEEC left a comment

kyranet left a comment

Thumuss commented Jun 9, 2021 •

edited

Thumuss commented Jun 10, 2021 •

edited

feat(Widget): wrapper for widget.json #5619

feat(Widget): wrapper for widget.json #5619

Conversation

Thumuss commented May 13, 2021 • edited

Thumuss commented May 13, 2021 • edited

Thumuss commented May 13, 2021 • edited

Thumuss commented May 27, 2021 • edited

SpaceEEC left a comment

Choose a reason for hiding this comment

kyranet left a comment

Choose a reason for hiding this comment

Thumuss commented Jun 9, 2021 • edited

Thumuss commented Jun 10, 2021 • edited

Thumuss commented May 13, 2021 •

edited

Thumuss commented May 13, 2021 •

edited

Thumuss commented May 13, 2021 •

edited

Thumuss commented May 27, 2021 •

edited

Thumuss commented Jun 9, 2021 •

edited

Thumuss commented Jun 10, 2021 •

edited