feat(Rest): optional ratelimit errors #5659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this can be configured via the disableRateLimitQueue client option, which may be an array of routes or a function
NotSugden
reviewed
May 21, 2021
|
I have no idea how to look at the docs json in my browser so they are untested |
vladfrangu
previously requested changes
May 23, 2021
SpaceEEC
requested changes
May 26, 2021
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
|
Is this better? |
vladfrangu
previously requested changes
May 29, 2021
|
@Vendicated if you could apply those changes requested we can move forward with merging this. |
|
sorry, I forgot 😅 |
kyranet
approved these changes
Jun 7, 2021
vladfrangu
previously requested changes
Jun 7, 2021
vladfrangu
approved these changes
Jun 8, 2021
ckohen
added a commit
to ckohen/discord.js-modules
that referenced
this pull request
Oct 25, 2021
Ported from discordjs/discord.js#5659 Co-authored-by: Ven <vendicated@riseup.net> Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
ckohen
added a commit
to ckohen/discord.js-modules
that referenced
this pull request
Oct 26, 2021
Ported from discordjs/discord.js#5659 Co-authored-by: Ven <vendicated@riseup.net> Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
ckohen
added a commit
to ckohen/discord.js-modules
that referenced
this pull request
Oct 30, 2021
Ported from discordjs/discord.js#5659 Co-authored-by: Ven <vendicated@riseup.net> Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
ckohen
added a commit
to ckohen/discord.js-modules
that referenced
this pull request
Nov 3, 2021
Ported from discordjs/discord.js#5659 Co-authored-by: Ven <vendicated@riseup.net> Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds new client option disableRateLimitQueue which takes either an array of routes or
(ratelimitData) => boolean.If a rate limit is hit, the RequestHandler first checks whether this rate limit should be thrown (route starts with one of the array values / function returns true) and if so throws an error instead of queueing the request
This closes #5449
Status and versioning classification: