Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Guild): add the new nsfw_level property #5660

Merged
merged 8 commits into from May 27, 2021

Conversation

iShibi
Copy link
Contributor

@iShibi iShibi commented May 22, 2021

Please describe the changes this PR makes and why it should be merged:

This PR adds the new nsfw_level guild property.
Source: discord-api-docs

Status and versioning classification:

  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • I know how to update typings and have done so

Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add an enum in the constants, so users don't have to use magic numbers.

@iShibi
Copy link
Contributor Author

iShibi commented May 22, 2021

I looked at how the already existing enums are being used and as a result of it made some big changes in 606376b. Please let me know if I made any mistake 😺

src/structures/Guild.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
src/structures/Guild.js Outdated Show resolved Hide resolved
src/util/Constants.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
Co-authored-by: Noel <icrawltogo@gmail.com>
src/structures/Guild.js Outdated Show resolved Hide resolved
src/structures/Guild.js Outdated Show resolved Hide resolved
src/util/Constants.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
@iCrawl iCrawl merged commit 3fe7add into discordjs:master May 27, 2021
@iShibi iShibi deleted the feat-nsfw-level branch May 30, 2021 10:22
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants