Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CommandInteraction): channel type should be text based channels #5690

Merged
merged 3 commits into from Jun 2, 2021
Merged

fix(CommandInteraction): channel type should be text based channels #5690

merged 3 commits into from Jun 2, 2021

Conversation

zLupa
Copy link
Contributor

@zLupa zLupa commented May 28, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:

This PR change the Channel type from CommandInteraction to TextChannel, DMChannel, and NewsChannel because Slash Commands can't be used in another channel type than text

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@zLupa
fix(CommandInteraction): channel type should be TextChannel
595b424 
Slash Commands can only be used in TextChannel
@almostSouji
Copy link
Member

Yes, they can, in other text-based channels (at the moment that being NewsChannel, soon also thread)

@zLupa
Copy link
Contributor Author

zLupa commented May 28, 2021

Yes, they can, in other text-based channels (at the moment that being NewsChannel, soon also thread)

Yep, you're right, I will update to TextChannel, DMChannel, and NewsChannel.
Seems that now is right

@zLupa zLupa changed the title fix(CommandInteraction): channel type should be TextChannel fix(CommandInteraction): channel type should be text based channels May 28, 2021
@iShibi
Copy link
Contributor

iShibi commented May 29, 2021

I'm late here but shouldn't the docs need to be updated too?

@iCrawl iCrawl merged commit 5141ea4 into discordjs:master Jun 2, 2021
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zLupa @almostSouji @iShibi @vladfrangu @iCrawl @kyranet @SpaceEEC