Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MessageSelectMenu): droppybois #5692

Merged
merged 27 commits into from Jun 24, 2021
Merged

feat(MessageSelectMenu): droppybois #5692

merged 27 commits into from Jun 24, 2021

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented May 28, 2021 •
edited

Select Menus are still in private beta. This PR will not function if you do not have access.

Changelog

  • New class MessageSelectMenu
  • New types MessageSelectMenuOptions, MessageSelectOption, MessageSelectOptionData
  • New utility method resolvePartialEmoji for resolving emoji without a Client
  • Improved emoji resolving in MessageButton, also applied to MessageSelectOption (fixes MessageButton#emoji throws invalid form body error #5753)
  • Improved consistency of documentation across all component classes

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@castdrian castdrian mentioned this pull request May 28, 2021
Merged
KuryKat
KuryKat approved these changes May 28, 2021
View reviewed changes
Copy link

@KuryKat KuryKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great changes, it will be great to be able to use it soon! :D👍

@HarmoGlace HarmoGlace mentioned this pull request May 28, 2021
Merged
@iCrawl iCrawl linked an issue May 29, 2021 that may be closed by this pull request
Request for adding support for message components #5682
Closed
@monbrey monbrey force-pushed the droppybois branch 6 times, most recently from 93b66f9 to 4c655b3 Compare May 30, 2021 08:27
@slugcat-dev slugcat-dev mentioned this pull request May 30, 2021
Closed
@monbrey monbrey force-pushed the droppybois branch 3 times, most recently from 2ebbbc2 to 8c5003a Compare June 1, 2021 06:27
@SpaceEEC SpaceEEC mentioned this pull request Jun 1, 2021
Merged
@monbrey monbrey force-pushed the droppybois branch 4 times, most recently from 1308e4c to e9b2551 Compare June 2, 2021 02:43
@monbrey monbrey force-pushed the droppybois branch 5 times, most recently from 4d88839 to b9754ed Compare June 4, 2021 22:49
@iCrawl iCrawl requested review from SpaceEEC and kyranet June 5, 2021 06:15
monbrey and others added 22 commits June 25, 2021 07:14
@monbrey
chore: transform min/max correctly
840f37f
@monbrey
types: done
b8d0e42
@monbrey
fix: emoji typings
0bb5e1a
@monbrey
feat: stricter types for components
b5f822f
@monbrey
fix: splice method
320cb86
@monbrey
docs: update after rebase
f6bd2c3
@monbrey
docs: updates to MessageSelectMenu
47e4b3f
@monbrey
types: remove MessageSelectMenu#addOption
3088880
@monbrey
docs: updates and consistency
4106506
@monbrey
docs: realised docgen does not need links here
b751e82
@monbrey
feat: verify strings
993f708
@monbrey
feat: improved emoji resolution for components
c3cab42
@monbrey
fix: max_values binding order
3c35454
@monbrey
feat: support for disabling
a9b46a7
@monbrey
docs: minor update
221f5a3
@monbrey
chore: final fixes
c3c0594
@monbrey
refactor: component interaction classes
315e86d
@monbrey
chore: minor rebase cleanup
6686469
@monbrey @kyranet
fix; update typings/index.d.ts
d182d2e 
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
@monbrey
types: extendable
1c6ceb4
@monbrey
docs: fix incorrect return type
8d242f2
@monbrey
refactor(Interaction): use enum
33f284e
@iCrawl iCrawl merged commit e5fcf0b into discordjs:master Jun 24, 2021
@monbrey monbrey deleted the droppybois branch June 24, 2021 21:31
@BannerBomb BannerBomb mentioned this pull request Jun 24, 2021
Closed
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
@bleuthoot-sven
Copy link

Looks like Selection Menus have been added to the documentation. I assume they have been released now:

https://discord.com/developers/docs/interactions/message-components#select-menus

@advaith1
Copy link
Contributor

advaith1 commented Jul 1, 2021

yes, it was announced yesterday:

image

@monbrey
Copy link
Member Author

monbrey commented Jul 2, 2021

This was also merged over a week ago so not sure why it matters to this PR that docs were released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckohen ckohen ckohen left review comments

@advaith1 advaith1 advaith1 left review comments

@NotSugden NotSugden NotSugden left review comments

@almostSouji almostSouji almostSouji requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@KuryKat KuryKat KuryKat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

MessageButton#emoji throws invalid form body error Request for adding support for message components