Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Interaction): add missing types and fix docs lists #5762

Merged
merged 3 commits into from Jun 5, 2021

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Jun 5, 2021

Please describe the changes this PR makes and why it should be merged:
This fixes #5751 as well as a bug in two typedefs that had their possible types listed incorrectly.
Decided to make this smaller PR to fix that issue as it can be quite annoying for users that are just now starting to try MessageComponents to have to wait for #5692 to be merged, as this will clearly take a while

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

typings/index.d.ts Outdated Show resolved Hide resolved
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
@ImRodry ImRodry requested a review from SpaceEEC June 5, 2021 19:59
@iCrawl iCrawl merged commit 1d57754 into discordjs:master Jun 5, 2021
@ImRodry ImRodry deleted the interaction-componenttype branch June 5, 2021 20:05
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interaction#componentType
3 participants