Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Client): make use of with_expiration in #fetchInvite #5764

Merged
merged 1 commit into from Jun 7, 2021
Merged

feat(Client): make use of with_expiration in #fetchInvite #5764

merged 1 commit into from Jun 7, 2021

Conversation

almostSouji
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Make use of the new with_expiration query option in Client#fetchInvite as per discord/discord-api-docs#2858 (comment)

  • leave fallback via age when not fetching via Client

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl merged commit bf191df into discordjs:master Jun 7, 2021
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
@almostSouji almostSouji deleted the invite-expiration branch July 6, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@almostSouji @vladfrangu @iCrawl @kyranet @SpaceEEC