Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: general component improvements #5787

Merged
merged 3 commits into from Jun 9, 2021
Merged

feat: general component improvements #5787

merged 3 commits into from Jun 9, 2021

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Jun 9, 2021 •
edited

By request, this PR extract several of the general improvements I had discovered while working on #5692 into a separate PR.

  • Subclasses for MessageComponentInteraction per component type
  • Support for parsing arrays of components as rows in raw options
  • Improved raw emoji resolution in component builders
  • Typings fixes
  • Documentation improvements and consistency

Please move lines that apply to you out of the comment:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@monbrey monbrey marked this pull request as ready for review June 9, 2021 08:25
SpaceEEC
SpaceEEC previously requested changes Jun 9, 2021
View reviewed changes
src/structures/APIMessage.js Outdated Show resolved Hide resolved
src/util/Util.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
src/util/Util.js Outdated Show resolved Hide resolved
@iCrawl
Copy link
Member

iCrawl commented Jun 9, 2021

This needs a rebase.

@kyranet kyranet requested a review from SpaceEEC June 9, 2021 12:46
@iCrawl iCrawl merged commit c4f1c75 into discordjs:master Jun 9, 2021
@monbrey monbrey deleted the component-improvements branch June 9, 2021 18:05
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@monbrey @iCrawl @vladfrangu @kyranet @SpaceEEC