Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BitField): ensure missing returns an array of strings #5795

Merged
merged 1 commit into from Jun 10, 2021

Conversation

SpaceEEC
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Currently BitField#missing assumes the passed bits are, if an array, an array of strings, this is not necessarily correct.
For example

const missing = new Permissions([Permissions.FLAGS.SEND_MESSAGES, Permissions.FLAGS.VIEW_CHANNEL])
    .missing([Permissions.FLAGS.VIEW_CHANNEL, Permissions.FLAGS.BAN_MEMBERS]);
console.log(missing); // [ 4n ] instead of [ "BAN_MEMBERS" ]

This PR ensures that BitField#missing always returns an array of strings.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code just looks so much more efficient, I like it.

@iCrawl iCrawl merged commit 68f7aeb into discordjs:master Jun 10, 2021
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants