Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Guild): add enum for mfa_level #5797

Merged
merged 1 commit into from Jun 10, 2021
Merged

Conversation

iShibi
Copy link
Contributor

@iShibi iShibi commented Jun 10, 2021

Please describe the changes this PR makes and why it should be merged:

Currently, mfaLevel prop of Guild gets set to the raw data sent by the API. This PR adds an MFALevels enum to make Guild#mfaLevel a bit more meaningful and not just a number.

Status and versioning classification:

  • Code changes have been tested against the Discord API
  • I know how to update typings and have done so
  • This PR includes breaking changes

@iCrawl iCrawl merged commit ffabec3 into discordjs:master Jun 10, 2021
@iShibi iShibi deleted the feat-mfa-enum branch June 15, 2021 15:00
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants