fix(*): typedefs and typings for image & webhook options #5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCrawl
approved these changes
Jun 11, 2021
kyranet
approved these changes
Jun 11, 2021
vladfrangu
approved these changes
Jun 11, 2021
SpaceEEC
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
While working on #5785, I found some inconsistencies between typedefs and typings of options for editing/creating webhook and fetching image. For eg, the typings for
Webhook#editshow that it takes only a single param, whereas in code it takes an object as first param andreasonas second. Similarly, theImageURLOptionstypedef is used for even those methods that don't support/usedynamicparam at all. This PR fixes all these inconsistencies by adding new typedefs and interfaces for these options.Status and versioning classification: