Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PermissionOverwrites): optional allow/deny OverwriteData #5810

Merged
merged 1 commit into from Jun 11, 2021
Merged

fix(PermissionOverwrites): optional allow/deny OverwriteData #5810

merged 1 commit into from Jun 11, 2021

Conversation

JKLorenzo
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Fixes #5808

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl merged commit a7ebb21 into discordjs:master Jun 11, 2021
@JKLorenzo JKLorenzo deleted the fix--permission-overwrites branch June 12, 2021 06:03
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

permissionOverwrites requires valid PermissionResolvable for both allow and deny
4 participants
@JKLorenzo @iCrawl @kyranet @SpaceEEC