fix(GuildChannel): don't force parentID/permissionOverwrites to empty on create #5823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
approved these changes
Jun 11, 2021
iCrawl
approved these changes
Jun 11, 2021
SpaceEEC
approved these changes
Jun 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
In #5796 a change was made that forced
parentIDto be null andpermissionOverwritesto be an empty collection on all GuildChannels when they are created. This PR changes that logic to only apply those defaults if they're not set by the initial patch during the super call.This should resolve the issue of channels firing an update event with parentID changing when they're patched by an event for the first time since the client starts.
Kudos to muchnameless for spotting this before I could.
Status and versioning classification: