Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GuildManager): #create throws when systemChannelFlags is undefined #5832

Merged
merged 2 commits into from Jun 12, 2021

Conversation

iShibi
Copy link
Contributor

@iShibi iShibi commented Jun 12, 2021

Please describe the changes this PR makes and why it should be merged:

This PR fixes a bug in GuildManager#create where it throws error if the optional systemChannelFlags param isn't provided. This happens because the method calls SystemChannelFlags#resolve without checking whether systemChannelFlags is defined or not. Since, it's an optional param, it can be undefined sometimes and passing undefined param to SystemChannelFlags#resolve always throws error.

Status and versioning classification:

  • Code changes have been tested against the Discord API

@iCrawl iCrawl merged commit 29173bf into discordjs:master Jun 12, 2021
@iShibi iShibi deleted the fix-sys-chan-flag branch June 15, 2021 15:00
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants