fix(ApplicationCommand): default option.required to false #5838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
approved these changes
Jun 12, 2021
iCrawl
reviewed
Jun 12, 2021
iCrawl
approved these changes
Jun 12, 2021
|
This didn’t cross my mind when making the PR but SUB_COMMAND and SUB_COMMAND_GROUP types cannot have the required value set so I’ll need to do some adjusting to catch those cases and set it to undefined then |
|
Oopsie |
ImRodry
added a commit
to BanTheNons/hypixel-translators-bot
that referenced
this pull request
Jun 13, 2021
Just need to wait for discordjs/discord.js#5838 to be merged so that I can get rid of the bad patch in ready.ts line 141
vladfrangu
approved these changes
Jun 13, 2021
SpaceEEC
approved these changes
Jun 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
The data sent by Discord for the
requiredfield in ApplicationCommandOption is undefined if the option is not required. This PR fixes this so that it defaults to false instead to make it easier to compare with local commands for command updaters.Status and versioning classification: