feat(MessageComponentInteraction): component getter #5840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
previously requested changes
Jun 20, 2021
| get component() { | ||
| return this.message.components | ||
| .map(row => row.components) | ||
| .flat() |
There was a problem hiding this comment.
Is flat defaulted to Infinity?
There was a problem hiding this comment.
Default depth is 1, though not sure it makes a difference here based on the data the API gives us.
|
Lint CI is failing here. |
vaporoxx
reviewed
Jun 24, 2021
DTrombett
reviewed
Jun 24, 2021
|
This needs a rebase too. |
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
monbrey
force-pushed
the
component-getter
branch
from
a7555c9
to
4998189
Compare
iCrawl
approved these changes
Jun 25, 2021
vladfrangu
approved these changes
Jun 25, 2021
kyranet
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5828
This currently uses generic Object/unknown typings for a raw message component, pending discordjs/discord-api-types#132 being merged.
Status and versioning classification: