New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): use enums for consistency and speed #5843
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
approved these changes
Jun 13, 2021
kyranet
requested changes
Jun 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, wrong button... ^
kyranet
approved these changes
Jun 13, 2021
vladfrangu
previously requested changes
Jun 13, 2021
SpaceEEC
approved these changes
Jun 13, 2021
iCrawl
approved these changes
Jun 14, 2021
This needs a rebase. |
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Okay, there are a lot of related changes here:
indexOf
is slow).WebhookTypes
enum (ex-array) was missing from typings forConstants
number
type.DefaultMessageNotifcations
is nowDefaultMessageNotificationLevels
to keep the naming consistent with other enums in djs (discord uses 'level' in the name for enums in documentaion).DefaultMessageNotifcations
types were not same as what the api has documented ( eg.ALL
instead ofALL_MESSAGES
)name
property's value isCustom_Status
, thetype
for it is documented asCustom
. So, the activity typeCUSTOM_STATUS
is nowCUSTOM
.Status and versioning classification: