Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stage instance invite #5856

Merged
merged 9 commits into from Jun 17, 2021
Merged

feat: stage instance invite #5856

merged 9 commits into from Jun 17, 2021

Conversation

iShibi
Copy link
Contributor

@iShibi iShibi commented Jun 14, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:

This PR starts the work of adding support for stage_instance field in the invite object.

Status and versioning classification:

  • Code changes have been tested against the Discord API
  • I know how to update typings and have done so
  • This PR changes the library's interface (methods or parameters added)

@advaith1
Copy link
Contributor

I'd call this InviteStageInstance (like I did in the docs) since it's data describing the stage instance, not the invite

@iShibi iShibi marked this pull request as ready for review June 16, 2021 18:21
@iShibi
Copy link
Contributor Author

iShibi commented Jun 16, 2021

This is ready for review.

@iShibi @kyranet
fix(InviteStageInstance): clear members collection before patching
b720892 
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
SpaceEEC
SpaceEEC requested changes Jun 16, 2021
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing

src/structures/InviteStageInstance.js Outdated Show resolved Hide resolved
@iCrawl iCrawl merged commit 2d12db0 into discordjs:master Jun 17, 2021
@iShibi iShibi deleted the feat-instance-invite branch June 18, 2021 07:13
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iShibi @advaith1 @iCrawl @kyranet @SpaceEEC