Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Sticker): updates, sticker packs, and guild stickers #5867

Merged
merged 47 commits into from Jul 19, 2021
Merged

feat(Sticker): updates, sticker packs, and guild stickers #5867

merged 47 commits into from Jul 19, 2021

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Jun 16, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:

  • Removes deprecated sticker.asset (which is just an empty string now)
  • Updates URL (old one doesn't work anymore)
  • Adds sticker properties: type, packID, available, guild, guildID, user, sortValue, fetchPack(), edit(), delete(), equals()
  • Adds StickerPack
  • Adds Client#fetchSticker(id)
  • Adds Client#fetchNitroStickerPacks()
  • Renames MANAGE_EMOJIS permission to MANAGE_EMOJIS_AND_STICKERS as requested by Jethro, to reflect client update
  • Adds sending stickers (stickers in MessageOptions)
  • Adds Guild#stickers and GuildStickerManager
  • Adds stickerCreate, stickerUpdate, and stickerDelete events
  • Renames GUILD_EMOJIS intent to GUILD_EMOJIS_AND_STICKERS
  • Adds sticker audit log events

discord/discord-api-docs#3127
discord/discord-api-docs#3171
discord/discord-api-docs#3128

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

advaith1
advaith1 commented Jun 16, 2021
View reviewed changes
src/structures/Sticker.js Outdated Show resolved Hide resolved
@advaith1 advaith1 changed the title feat(Sticker): update sticker properties feat(Sticker): update sticker properties and add StickerPack Jun 17, 2021
@advaith1
Copy link
Contributor Author

ok, I think this is ready for review?

it doesn't add GuildStickerManager or the guild sticker update gw event bc those can't really be tested now, but I've tested everything added

@advaith1 advaith1 marked this pull request as ready for review June 17, 2021 06:10
kyranet
kyranet reviewed Jun 17, 2021
View reviewed changes
src/util/Constants.js Outdated Show resolved Hide resolved
SpaceEEC
SpaceEEC previously requested changes Jun 17, 2021
View reviewed changes
src/structures/Sticker.js Outdated Show resolved Hide resolved
kyranet
kyranet requested changes Jun 19, 2021
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just three small things, otherwise LGTM

src/client/Client.js Outdated Show resolved Hide resolved
src/client/Client.js Outdated Show resolved Hide resolved
src/client/Client.js Outdated Show resolved Hide resolved
kyranet
kyranet requested changes Jun 19, 2021
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just three small things, otherwise LGTM

advaith1 and others added 2 commits June 19, 2021 03:17
@advaith1 @kyranet
Edit fetchSticker desc
ee953d9 
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
@advaith1
style: switch from .then to async/await
3545ca2
SpaceEEC
SpaceEEC previously requested changes Jun 19, 2021
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looking good

src/client/Client.js Outdated Show resolved Hide resolved
src/client/Client.js Outdated Show resolved Hide resolved
@kyranet kyranet requested a review from SpaceEEC June 19, 2021 22:56
ThaTiemsz
ThaTiemsz reviewed Jun 20, 2021
View reviewed changes
src/client/Client.js Outdated Show resolved Hide resolved
@iCrawl iCrawl self-requested a review July 7, 2021 12:41
vladfrangu
vladfrangu requested changes Jul 7, 2021
View reviewed changes
src/rest/APIRequest.js Outdated Show resolved Hide resolved
@DarkView DarkView mentioned this pull request Jul 7, 2021
Closed
@advaith1 advaith1 changed the title feat(Sticker): update sticker properties and add StickerPack feat(Sticker): updates, sticker packs, and guild stickers Jul 7, 2021
@advaith1 advaith1 requested a review from vladfrangu July 7, 2021 19:15
vladfrangu
vladfrangu approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase

NotSugden
NotSugden reviewed Jul 14, 2021
View reviewed changes
src/managers/GuildStickerManager.js Outdated Show resolved Hide resolved
src/rest/APIRequest.js Outdated Show resolved Hide resolved
advaith1 and others added 4 commits July 13, 2021 20:09
@advaith1 @NotSugden
style: use optional chaining
60ae9ff 
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
@advaith1 @NotSugden
style: return new collection directly
31ca245 
Co-Authored-By: Sugden <28943913+NotSugden@users.noreply.github.com>
@advaith1
feat(Permissions): add USE_EXTERNAL_STICKERS
8193e0f
@advaith1
feat(ApiErrors): add 170007
a3b9a52
@iCrawl
Copy link
Member

iCrawl commented Jul 17, 2021

This needs a rebase.

@GitMuslim
Copy link

you aware changes weren't merged?

@kyranet
Copy link
Member

kyranet commented Jul 19, 2021

Upstream PR has landed, and this needs a rebase 😄

@iCrawl iCrawl merged commit 54d6a3a into discordjs:master Jul 19, 2021
@advaith1 advaith1 deleted the sticker-updates branch July 19, 2021 23:18
ckohen added a commit to ckohen/discord.js-modules that referenced this pull request Nov 14, 2021
@ckohen @advaith1
feat(Requests): add attachment keys and form data for stickers
7ad45b1 
Ported from discordjs/discord.js#5867

Co-authored-by: Advaith <advaithj1@gmail.com>
ckohen added a commit to ckohen/discord.js-modules that referenced this pull request Nov 14, 2021
@ckohen @advaith1
feat(Requests): add attachment keys and form data for stickers
62843d6 
Ported from discordjs/discord.js#5867

Co-authored-by: Advaith <advaithj1@gmail.com>
@ckohen ckohen mentioned this pull request Nov 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BannerBomb BannerBomb BannerBomb left review comments

@ThaTiemsz ThaTiemsz ThaTiemsz requested changes

@kyranet kyranet kyranet approved these changes

@NotSugden NotSugden NotSugden left review comments

@almeidx almeidx almeidx left review comments

@DTrombett DTrombett DTrombett left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet