feat(Managers): ✨ Add GuildInviteManager #5889

DraftProducts · 2021-06-20T14:37:19Z

Please describe the changes this PR makes and why it should be merged:

The InviteManager was missing, this new Manager comes with some extra features

Invites generation from Guild based on the first accessible channel
Invite deletion outside of an Invite instance
Fetch a single invite with cache filling to avoid unnecessary future requests (force option is available)

Status and versioning classification:

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating
This PR changes the library's interface (methods or parameters added)

The InviteManager was missing, this new Manager comes with some extra features - Invites generation from Guild based on the first accessible channel - Invite deletion outside of an Invite instance - Fetch a single invite with cache filling to avoid unnecessary future requests (force option is available)

src/errors/Messages.js

typings/index.d.ts

Co-authored-by: iShibi <shubhamparihar391@gmail.com>

vladfrangu

At this point, couldn't we get a GuildChannelInviteManager too? /s
Jokes aside, here are some things I'd like to bring up

src/errors/Messages.js

src/managers/GuildInviteManager.js

Correction of docs and errors messages Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

typings/index.d.ts

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

Co-authored-by: iShibi <shubhamparihar391@gmail.com>

…with APIErrors Co-authored-by: iShibi <shubhamparihar391@gmail.com>

DraftProducts

I think everything is good if you don't have other suggestions for changes 👍

src/errors/Messages.js

Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>

Stale

src/managers/GuildInviteManager.js

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

Stale

src/managers/GuildInviteManager.js

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

Co-authored-by: Antonio Román <kyradiscord@gmail.com>

kyranet

Just one thing I noticed:

src/managers/GuildInviteManager.js

Co-authored-by: Antonio Román <kyradiscord@gmail.com>

…r cache

Co-authored-by: Antonio Román <kyradiscord@gmail.com>

DraftProducts

I merged master to resolve conflicts with breaking changes of Guild#fetchInvites()

Stale

src/structures/GuildChannel.js

Co-authored-by: SpaceEEC <spaceeec@yahoo.com>

iCrawl · 2021-07-04T01:00:46Z

This needs a rebase.

kyranet

Just the rebase, otherwise LGTM.

iCrawl

ID -> Id changes required.

src/managers/GuildInviteManager.js

DraftProducts · 2021-07-04T19:05:12Z

Arf I was already working on it 👀

Co-authored-by: iCrawl <icrawltogo@gmail.com>

advaith1 · 2021-07-05T01:40:18Z

was this actually tested? it seems to not actually add the Guild#invites property, breaking all the places which now try to access it 😬

DraftProducts commented Jun 20, 2021

View reviewed changes

src/errors/Messages.js Outdated Show resolved Hide resolved

iShibi suggested changes Jun 20, 2021

View reviewed changes

typings/index.d.ts Outdated Show resolved Hide resolved

typings/index.d.ts Outdated Show resolved Hide resolved

types(GuildInviteManager) Fix pluralization of class name in typings

9f6f82e

Co-authored-by: iShibi <shubhamparihar391@gmail.com>

iCrawl requested review from SpaceEEC, vladfrangu and kyranet June 20, 2021 14:50

vladfrangu previously requested changes Jun 20, 2021

View reviewed changes

DraftProducts and others added 2 commits June 20, 2021 18:03

refactor: 💬 Adds literary corrections

c576e4b

Correction of docs and errors messages Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

refactor: 🥅 Transform sync errors to Promise rejections

f97bcc5

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

iShibi reviewed Jun 20, 2021

View reviewed changes

typings/index.d.ts Outdated Show resolved Hide resolved

DraftProducts and others added 2 commits June 20, 2021 18:19

fix: 🐛 Remove mutating in case of options is a frozen object

921c81f

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

types: 🏷️ Replace InviteOptions with CreateInviteOptions

8bfd39a

Co-authored-by: iShibi <shubhamparihar391@gmail.com>

DraftProducts requested a review from vladfrangu June 20, 2021 16:26

refactor(Errors): 🥅 Change "unknown invite" error to avoid confusion …

3bc3be9

…with APIErrors Co-authored-by: iShibi <shubhamparihar391@gmail.com>

DraftProducts commented Jun 20, 2021

View reviewed changes

NotSugden reviewed Jun 20, 2021

View reviewed changes

src/errors/Messages.js Outdated Show resolved Hide resolved

fix(Errors): Update quotes & formulation

1890cd1

Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>

vladfrangu previously requested changes Jun 22, 2021

View reviewed changes

src/managers/GuildInviteManager.js Outdated Show resolved Hide resolved

src/managers/GuildInviteManager.js Outdated Show resolved Hide resolved

docs: Provide more details in docs about invite creation

8b727b8

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

iCrawl requested a review from vladfrangu June 22, 2021 22:38

DraftProducts added 2 commits June 23, 2021 01:07

refactor: ♻️ Move channel parameter to options

186b152

types(options): 🏷️ Fix options types

ae9916d

iCrawl added semver: minor labels Jun 23, 2021

vladfrangu previously requested changes Jun 23, 2021

View reviewed changes

src/managers/GuildInviteManager.js Outdated Show resolved Hide resolved

refactor: Change [] to ()

edced3a

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

refactor: ♻️ Remove useless type check

7844337

Co-authored-by: Antonio Román <kyradiscord@gmail.com>

kyranet previously requested changes Jul 3, 2021

View reviewed changes

src/managers/GuildInviteManager.js Outdated Show resolved Hide resolved

DraftProducts and others added 5 commits July 3, 2021 17:17

docs(GuildInviteManager): Simplification of typedoc return schem

c735461

Co-authored-by: Antonio Román <kyradiscord@gmail.com>

refactor: ⚡️ Improve GuildChannel#fetchInvites with GuildInviteManage…

bff9de7

…r cache

docs(GuildInviteManager): 🏷️ Fix cache option typing

70423b6

Co-authored-by: Antonio Román <kyradiscord@gmail.com>

fix: 🚑 Fix breaking changes in GuildAuditLogs initialization

a1d8509

Merge branch 'master' into feature-invite-manager

8bc7fd6

DraftProducts commented Jul 3, 2021

View reviewed changes

DraftProducts requested review from kyranet and SpaceEEC July 3, 2021 15:47

SpaceEEC requested changes Jul 3, 2021

View reviewed changes

src/structures/GuildChannel.js Outdated Show resolved Hide resolved

feat(GuildChannel): ✨ Add cache option to GuildChannel#fetchInvites

5be49e9

Co-authored-by: SpaceEEC <spaceeec@yahoo.com>

DraftProducts requested a review from SpaceEEC July 3, 2021 21:13

SpaceEEC approved these changes Jul 3, 2021

View reviewed changes

kyranet approved these changes Jul 4, 2021

View reviewed changes

iCrawl requested changes Jul 4, 2021

View reviewed changes

Merge branch 'master' into feature-invite-manager

bb0b368

refactor(GuildInviteManager): ♻️ Add changes due to methods changes

3135046

Co-authored-by: iCrawl <icrawltogo@gmail.com>

DraftProducts requested a review from iCrawl July 4, 2021 19:11

types(GuildInviteManager): 🏷️ Fix typings due to external changes

bdcceb0

iCrawl approved these changes Jul 4, 2021

View reviewed changes

iCrawl merged commit 9e08b02 into discordjs:master Jul 4, 2021

DraftProducts deleted the feature-invite-manager branch July 4, 2021 22:26

monbrey mentioned this pull request Jul 5, 2021

fix(Guild): add invite manager property, extend CachedManager #6049

Merged

kyranet mentioned this pull request Jul 18, 2021

fix(GuildChannel): only fetch invites for the specific channel #6132

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Managers): ✨ Add GuildInviteManager #5889

feat(Managers): ✨ Add GuildInviteManager #5889

DraftProducts commented Jun 20, 2021

vladfrangu left a comment

DraftProducts left a comment

kyranet left a comment

DraftProducts left a comment •

edited

iCrawl commented Jul 4, 2021

kyranet left a comment

iCrawl left a comment

DraftProducts commented Jul 4, 2021

advaith1 commented Jul 5, 2021 •

edited

feat(Managers): ✨ Add GuildInviteManager #5889

feat(Managers): ✨ Add GuildInviteManager #5889

Conversation

DraftProducts commented Jun 20, 2021

vladfrangu left a comment

Choose a reason for hiding this comment

DraftProducts left a comment

Choose a reason for hiding this comment

kyranet left a comment

Choose a reason for hiding this comment

DraftProducts left a comment • edited

Choose a reason for hiding this comment

iCrawl commented Jul 4, 2021

kyranet left a comment

Choose a reason for hiding this comment

iCrawl left a comment

Choose a reason for hiding this comment

DraftProducts commented Jul 4, 2021

advaith1 commented Jul 5, 2021 • edited

DraftProducts left a comment •

edited

advaith1 commented Jul 5, 2021 •

edited