Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MessageMentions): add repliedUser #5905

Merged
merged 2 commits into from Jun 25, 2021
Merged

feat(MessageMentions): add repliedUser #5905

merged 2 commits into from Jun 25, 2021

Conversation

vaporoxx
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

This PR adds a repliedUser property to the message mentions so that users can more quickly see which user was replied to.

Status and versioning classification:

  • Code changes have been tested against the Discord API
  • I know how to update typings and have done so
  • This PR changes the library's interface (methods or parameters added)

vladfrangu
vladfrangu previously requested changes Jun 23, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This as well as the point NotSugden said

src/structures/Message.js Outdated Show resolved Hide resolved
@kyranet kyranet requested a review from vladfrangu June 23, 2021 13:48
@iCrawl iCrawl merged commit 2616125 into discordjs:master Jun 25, 2021
@vaporoxx vaporoxx deleted the feat-mentions branch June 25, 2021 12:56
@MahouSirin MahouSirin mentioned this pull request Jun 26, 2021
Merged
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monbrey monbrey monbrey left review comments

@NotSugden NotSugden NotSugden left review comments

@ImRodry ImRodry ImRodry left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@vaporoxx @monbrey @vladfrangu @iCrawl @kyranet @SpaceEEC @NotSugden @ImRodry