Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Permissions): allow admin to override in the missing method #5911

Merged
merged 1 commit into from Jun 24, 2021
Merged

fix(Permissions): allow admin to override in the missing method #5911

merged 1 commit into from Jun 24, 2021

Conversation

SpaceEEC
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

This PR ensures that calling Permissions#missing on an instance with ADMINISTRATOR always returns an empty array, except when checkAdmin is false.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl merged commit ee025b0 into discordjs:master Jun 24, 2021
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
@DTrombett DTrombett mentioned this pull request Dec 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SpaceEEC @vladfrangu @iCrawl @kyranet