Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Webhook): resolve non-string avatars too #5914

Merged
merged 1 commit into from Jun 25, 2021
Merged

fix(Webhook): resolve non-string avatars too #5914

merged 1 commit into from Jun 25, 2021

Conversation

SpaceEEC
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

This PR fixes Webhook#edit to also resolve non-string avatars (read: buffers) into the required data uris.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl merged commit 4714a96 into discordjs:master Jun 25, 2021
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SpaceEEC @iCrawl @kyranet