refactor: removed code and split options
#5918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DTrombett
reviewed
Jun 24, 2021
iCrawl
approved these changes
Jun 24, 2021
kyranet
force-pushed
the
cleanup/remove-code-and-split
branch
from
b704865
to
e5c26aa
Compare
vaporoxx
reviewed
Jun 24, 2021
SpaceEEC
previously requested changes
Jun 25, 2021
There was a problem hiding this comment.
You missed one instance of splitting:
https://github.com/kyranet/discord.js/blob/dc02352247f67e290aefef1387cb768ffe92f61c/src/structures/Webhook.js#L169-L171
Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com> BREAKING CHANGE: Removed `APIMessage#split` BREAKING CHANGE: Removed `MessageEditOptions#code` BREAKING CHANGE: Removed `BaseMessageOptions#code` BREAKING CHANGE: Removed `BaseMessageOptions#split`
kyranet
force-pushed
the
cleanup/remove-code-and-split
branch
from
30c4720
to
dccdf1f
Compare
SpaceEEC
approved these changes
Jun 26, 2021
This was referenced Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
🧹 clean-up service here, removing old remnants from old versions of discord.js
APIMessage#splitMessageEditOptions#codeBaseMessageOptions#codeBaseMessageOptions#splitNo other method in the entire library does two requests to the same path. This method was an exception for many years, and is something that should always been done by the user.
You can still use the
Util.splitMessageutility, and then with given array, send all the messages as you desire.As for
code, simply wrap the content into ```js\n${content}```. We're releasing an utility later in the future too, so you can docodeblock('js', content).Status and versioning classification: