feat(RoleManager): added `edit` method, alias `Role#edit` #5983

kyranet · 2021-06-30T21:36:39Z

Please describe the changes this PR makes and why it should be merged:

Fixes #5634

Also implements RoleManager#edit to be consistent with many other managers.

Status and versioning classification:

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating
This PR changes the library's interface (methods or parameters added)

src/managers/RoleManager.js

Co-authored-by: monbrey <rsm999@uowmail.edu.au>

This is why we need TypeScript.

src/managers/RoleManager.js

feat(RoleManager): added edit method, alias Role#edit

6198085

kyranet added this to the Version 13 milestone Jun 30, 2021

kyranet added meta: refactor labels Jun 30, 2021

kyranet requested review from iCrawl, SpaceEEC and vladfrangu June 30, 2021 21:36

monbrey reviewed Jun 30, 2021

View reviewed changes

src/managers/RoleManager.js Outdated Show resolved Hide resolved

kyranet and others added 2 commits June 30, 2021 23:43

chore: updated types, improve code consistency

984bfef

Co-authored-by: monbrey <rsm999@uowmail.edu.au>

fix(RoleManager): added missing await

ab1d896

This is why we need TypeScript.

kyranet marked this pull request as ready for review June 30, 2021 21:53

iCrawl approved these changes Jun 30, 2021

View reviewed changes

SpaceEEC requested changes Jul 1, 2021

View reviewed changes

src/managers/RoleManager.js Outdated Show resolved Hide resolved

fix(RoleManager): pass a Role instance to setPosition

b1a5b52

kyranet requested a review from SpaceEEC July 1, 2021 10:53

SpaceEEC approved these changes Jul 1, 2021

View reviewed changes

vladfrangu approved these changes Jul 1, 2021

View reviewed changes

iCrawl merged commit 1e73c25 into discordjs:master Jul 1, 2021

kyranet deleted the feat/added-role-manager-edit branch July 1, 2021 21:57

Provide feedback