fix(Util): splitMessage not working with array #6008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mention types
Revert "Mention types"
muchnameless
reviewed
Jul 2, 2021
Co-authored-by: muchnameless <12682826+muchnameless@users.noreply.github.com>
Co-authored-by: muchnameless <12682826+muchnameless@users.noreply.github.com>
vladfrangu
approved these changes
Jul 2, 2021
kyranet
approved these changes
Jul 2, 2021
iCrawl
approved these changes
Jul 2, 2021
SpaceEEC
approved these changes
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6006
Please describe the changes this PR makes and why it should be merged:
This PR fixes a problem with Util.splitMessage which doesn't work when the
charoption is set to an array. This is because the array of messages is mapped and messages splitted again causing the creation of an array of arrays. This PR adds a.flat(1)to prevent this from happening. I also tested this with all options but let me know if there are still problems.Sorry for too many commits but I accidentally pushed the content of another PR into my master branch
Status and versioning classification: