Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Formatters): added new URL utilities and docs #6014

Merged
merged 5 commits into from Jul 3, 2021
Merged

feat(Formatters): added new URL utilities and docs #6014

merged 5 commits into from Jul 3, 2021

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Jul 3, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:

This PR brings two new formatters from discordjs/builders#4:

  • hideLinkEmbed
  • hyperlink

And alongside them, it also adds docs so they're visible in the docs website. , however, something I'm unsure of, is whether @namespace works.

cc: @iCrawl

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@kyranet kyranet added this to the Version 13 milestone Jul 3, 2021
SpaceEEC
SpaceEEC requested changes Jul 3, 2021
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

src/util/Formatters.js Outdated Show resolved Hide resolved
@kyranet @SpaceEEC
docs: remove empty line
b489b6a 
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
@iCrawl iCrawl merged commit 98e45a5 into discordjs:master Jul 3, 2021
@kyranet kyranet deleted the feat/added-url-formatters-and-docs branch July 3, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kyranet @vladfrangu @iCrawl @SpaceEEC