Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Client): enforce passing scopes to generateInvite #6024

Merged
merged 8 commits into from Jul 4, 2021

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Jul 3, 2021

Previously this method would automatically include the bot scope - it's now required that the user provide scopes in the options, including one of either bot or applications.commands.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@monbrey monbrey marked this pull request as draft July 3, 2021 22:06
@monbrey monbrey marked this pull request as ready for review July 3, 2021 22:07
@iCrawl iCrawl added this to the Version 13 milestone Jul 3, 2021
@iCrawl
Copy link
Member

iCrawl commented Jul 4, 2021

This needs a rebase.

src/client/Client.js Outdated Show resolved Hide resolved
src/client/Client.js Outdated Show resolved Hide resolved
src/client/Client.js Show resolved Hide resolved
src/client/Client.js Outdated Show resolved Hide resolved
src/errors/Messages.js Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
monbrey and others added 2 commits July 4, 2021 17:16
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

src/client/Client.js Outdated Show resolved Hide resolved
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than Space's review, LGTM

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than requested change, LGTM

Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
@kyranet kyranet requested a review from SpaceEEC July 4, 2021 21:44
@iCrawl iCrawl merged commit c6e5521 into discordjs:master Jul 4, 2021
@monbrey monbrey deleted the invite-scopes branch July 4, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants