New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow channels from uncached guilds to be returned from fetch #6034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing, LGTM otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ID
-> Id
changes required.
Additionally this needs a rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than requested changes, LGTM
This needs a rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect people using this option to know exactly what they are doing and which properties can be accessed.
We'll see about that 😄
This needs a rebase. |
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
Please describe the changes this PR makes and why it should be merged:
This PR allows fetching channels from guilds that do not exist in the client cache (applicable mostly when sharding, but also possible to have guilds uncached via intents limiting or the new collection based limiting)
A big red flag warning here: channels obviously rely on guild internally a lot, however I did not want to change types when the majority of times the values will be present. I would expect people using this option to know exactly what they are doing and which properties can be accessed.
This also fixes up fetching single channels from the guild channel manager, making it cleaner and throwing when trying to fetch a channel from a different guild (this is the only breaking change)
closes: #4929
Status and versioning classification: