Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TeamMember): Fixed incorrect return types. #6044

Merged
merged 2 commits into from Jul 4, 2021

Conversation

BannerBomb
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Fixes the typings for
Team#owner - the return type was missing null
Team#iconURL - the return type was missing null
TeamMember#toString - changed the return type to UserMention as for PR #6003

and changed the JSDOC for Team#ownerId to be type {?Snowflake} instead of {?string}.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the Version 13 milestone Jul 4, 2021
@iCrawl iCrawl changed the title fix(Team & TeamMember): Fixed incorrect return types. fix(TeamMember): Fixed incorrect return types. Jul 4, 2021
@iCrawl iCrawl merged commit fe5d56c into discordjs:master Jul 4, 2021
@BannerBomb BannerBomb deleted the patch-4 branch July 4, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants