Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SelectMenuInteraction): set values to empty array if not provided #6045

Merged
merged 3 commits into from Jul 5, 2021
Merged

fix(SelectMenuInteraction): set values to empty array if not provided #6045

merged 3 commits into from Jul 5, 2021

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Jul 4, 2021

Closes #6040

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@iCrawl iCrawl added this to the Version 13 milestone Jul 4, 2021
kyranet
kyranet approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how the type at SelectMenuInteraction#15 was wrong all this time, and now it's right.

@MahouSirin
Copy link
Contributor

LGTM, but Isn't the class name SelectMenuInteraction? I'm sorry if I did something wrong

@monbrey monbrey changed the title fix(SelectMenuInteration): set values to empty array if not provided fix(SelectMenuInteraction): set values to empty array if not provided Jul 5, 2021
@iCrawl
Copy link
Member

iCrawl commented Jul 5, 2021

This needs a rebase.

@iCrawl iCrawl merged commit 34708d6 into discordjs:master Jul 5, 2021
@monbrey monbrey deleted the menu-values branch August 1, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Jiralite Jiralite Jiralite approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

SelectMenuInteraction#values can be undefined
6 participants
@monbrey @MahouSirin @iCrawl @kyranet @SpaceEEC @Jiralite