Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Guild): add invite manager property, extend CachedManager #6049

Merged
merged 3 commits into from Jul 5, 2021
Merged

fix(Guild): add invite manager property, extend CachedManager #6049

merged 3 commits into from Jul 5, 2021

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Jul 5, 2021 •
edited

Adds the new GuildInviteManager to Guild as Guild#invites since #5889 didnt, and extend the new CachedManager.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@GoldenAngel2
Copy link
Contributor

Shouldn't GuildInviteManager extend CachedManager and not BaseManager ?

@monbrey monbrey changed the title fix(Guild): add invite manager fix(Guild): add invite manager property, extend CachedManager Jul 5, 2021
@kyranet kyranet added this to the Version 13 milestone Jul 5, 2021
SpaceEEC
SpaceEEC previously requested changes Jul 5, 2021
View reviewed changes
src/managers/GuildInviteManager.js Outdated Show resolved Hide resolved
@monbrey @SpaceEEC
docs: extends CacheManager
a507dec 
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
@iCrawl iCrawl requested a review from SpaceEEC July 5, 2021 11:00
@iCrawl iCrawl merged commit e3d877d into discordjs:master Jul 5, 2021
@monbrey monbrey deleted the guild-invites branch August 1, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@DarkPhoenix2704 DarkPhoenix2704 DarkPhoenix2704 approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@monbrey @GoldenAngel2 @iCrawl @kyranet @SpaceEEC @DarkPhoenix2704