Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Collector): better types for events #6058

Merged
merged 2 commits into from Jul 5, 2021
Merged

feat(Collector): better types for events #6058

merged 2 commits into from Jul 5, 2021

Conversation

vaporoxx
Copy link
Contributor

@vaporoxx vaporoxx commented Jul 5, 2021

Please describe the changes this PR makes and why it should be merged:

This changes the type of the collector event parameters from unknown to something actually helpful.

Status and versioning classification:

  • There are no code changes
  • I know how to update typings and have done so

@iCrawl iCrawl added this to the Version 13 milestone Jul 5, 2021
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should declare the names of the constants the same as their types to avoid name conflicts. We can use short names for local non-virtual variables, such as those within an event callback.

Other than this, LGTM.

typings/index.ts Outdated Show resolved Hide resolved
typings/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
@iCrawl iCrawl merged commit c0a814f into discordjs:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants